Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup old methods #1435

Merged
merged 7 commits into from
Jul 16, 2024
Merged

Cleanup old methods #1435

merged 7 commits into from
Jul 16, 2024

Conversation

jbrichau
Copy link
Member

@jbrichau jbrichau commented Jul 13, 2024 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Jul 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.97628% with 248 lines in your changes missing coverage. Please review.

Project coverage is 49.33%. Comparing base (cb4b8ef) to head (fde0005).

Files Patch % Lines
...deRemainingBecausePharo8LimitationOfLiteralsTo..st 0.00% 132 Missing ⚠️
...nalTest.class/instance/countriesPerCurrencyCode.st 0.00% 66 Missing ⚠️
...alTest.class/instance/currenciesAndCountriesOn..st 0.00% 10 Missing ⚠️
...eFunctionalTest.class/instance/countryNamesFor..st 0.00% 8 Missing ⚠️
...eFunctionalTest.class/instance/renderContentOn..st 0.00% 8 Missing ⚠️
...est.class/instance/renderSelectedCountryNameOn..st 0.00% 6 Missing ⚠️
...unctionalTest.class/instance/listOfCountryNames.st 0.00% 4 Missing ⚠️
...alTest.class/instance/countriesForCurrencyCode..st 0.00% 4 Missing ⚠️
...nctionalTest.class/instance/listOfCurrencyCodes.st 0.00% 4 Missing ⚠️
...pleteFunctionalTest.class/instance/countryNames.st 0.00% 4 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1435      +/-   ##
==========================================
+ Coverage   49.04%   49.33%   +0.29%     
==========================================
  Files        9143     9073      -70     
  Lines       80555    80055     -500     
==========================================
- Hits        39506    39498       -8     
+ Misses      41049    40557     -492

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbrichau jbrichau mentioned this pull request Jul 13, 2024
Open
@jbrichau jbrichau requested a review from marschall July 13, 2024 19:35
@marschall
Copy link
Contributor

Maybe I'm missing something here. Unfortunately we still have some senders of GRPackage class >> #grPackages

  • JQUiFunctionalTest >> #packages
  • JQFunctionalTest >> #seasidePackagesOn:
  • JQFunctionalTest >> #seasidePackagesOn:
  • WADevelopment class >> # graphFunctionalDependencies:tests:
  • WADevelopment class >> #allGRPackages
    • WADevelopment class >> #allDirtyPackages
    • WADevelopment class >> #browserEnvironment
    • WADevelopment class >> #cleanupCategories
    • WADevelopment class >> #gofers
    • WADevelopment class >> #graphFunctionalDependencies:tests:

@jbrichau
Copy link
Member Author

Yes, that was not so good... just did not check those.

  • In the functional tests, I replaced its use with something completely different (country names and currencies) to ensure these are not dependent on a specific platform.
  • In WADevelopment, I removed the methods that referred it. None of these have been in use for the last 10 years and are replaced by either Metacello or code critiques in Pharo.

marschall
marschall approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@marschall marschall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbrichau jbrichau merged commit c21b141 into master Jul 16, 2024
19 of 24 checks passed
@jbrichau jbrichau deleted the cleanup-old branch July 16, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marschall marschall marschall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrichau @marschall